Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export the
mergeConfig
utility function, as has been previously requested here.I believe tacking
mergeConfig
directly on to the default export is the simplest and most flexible solution, since addinglib/core/mergeConfig.js
to theexports
ofpackage.json
would require additional work on the build step to support CJS – and it also seems like a bit of an anti-pattern to expose individual files like that.I'm happy to discuss use-cases if anyone needs more convincing, but I think the author of #3905 already did a great job with that. The TL;DR is basically "the ability to merge configs within an interceptor is very useful, and trying to re-create that functionality is error-prone because
mergeConfig
has a ton of logic that's very specific toaxios
internals".